Skip to content

Fix location wherever it was wrongly defined #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2025
Merged

Fix location wherever it was wrongly defined #405

merged 2 commits into from
Jul 26, 2025

Conversation

gaeljw
Copy link
Member

@gaeljw gaeljw commented Jul 26, 2025

⚡️ What's your motivation?

#404

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

@gaeljw gaeljw linked an issue Jul 26, 2025 that may be closed by this pull request
@gaeljw gaeljw merged commit bd965a9 into main Jul 26, 2025
4 of 5 checks passed
@gaeljw gaeljw deleted the gh404 branch July 26, 2025 15:36
@mpkorstanje
Copy link
Contributor

Cheers! Stacktraces from exceptions thrown in hooks should be much shorter now.

@gaeljw
Copy link
Member Author

gaeljw commented Jul 27, 2025

I didn't add tests to cover it but I printed them and indeed they looked both "more correct" and shorter :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All ScalaHookDefinition.location point to same location
2 participants